Botond Dénes
Botond Dénes
v3: * Fix `test/cql-pytest/test_describe.py` TODO: Address the 2 failing dtests
> @denesb it looks like dtest are still failing Yes, I didn't fix them yet. Will send a PR today.
> > @denesb it looks like dtest are still failing > > Yes, I didn't fix them yet. Will send a PR today. https://github.com/scylladb/scylla-dtest/pull/4053
Dtest changes are in. Rebased to kick CI.
Ok, can we then rename this header to `tabular.hh` or something else, more specific. `writer.hh` is very generic name.
> @scylladb/scylla-maint hello maintainers, could you help queue this change? > > i have another patch conflict with it. so would be great if this one can be merged sooner....
I also would prefer keeping everything in `scylla-nodetool.cc`, but I also understand that it is getting a bit unwieldy. That said, once we are done with implementing all command, this...
I queued this, so we can move forward.
> It is rebased on #17400 but I believe it could be treated as a whole If we have this PR, do we even need https://github.com/scylladb/scylladb/pull/17400?
> @denesb are we good to merge? Yes, but we have a merge freeze in effect. Will queue after it is lifted.