demeritcowboy

Some thoughts on whether it should be protected vs public: 1. In the most general situation as I understand it, a decorator does not necessarily extend the original service class,...

I agree with all that. One idea but might be overkill is to break it down into more services, e.g. processing memberships could be its own service. Not sure if...

It just means they need to be public, but I don't think anybody was opposed to that, there's just the two breaking issues which probably aren't very common, and they...

Sorry it takes some time to get your head back into this... is the suggestion to break the services into smaller services? That seems like a valid option.

I'll take a look but that particular fail I think is something needing to be updated for all cmses, whether it be in core or the cms modules.

``` Deprecated function: Return type of Faps_Transaction::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed (line 30 of sites/simpletest/64253304/files/civicrm/ext/com.iatspayments.civicrm/CRM/Iats/FapsRequest.php) Deprecated function: current(): Calling current() on an object is deprecated in CRM_Iats_iATSServiceRequest->result()...