Maxime comments

Results 21 comments of


                                            Maxime

Use symfony/panther with Behat

Possible mink driver https://github.com/Lctrs/mink-panther-driver

Promotion: gives the possibility to define additional item filters

Hi @coldic3, I have refactored the code to use the tagged service. Does this seem right to you?

Promotion: gives the possibility to define additional item filters

Hi @coldic3 I just pushed a refactoring to use a service to apply the additional filters.

Promotion: gives the possibility to define additional item filters

@coldic3, I didn't see/read the notification, I just made the changes. Thanks for your reviews!

Promotion: gives the possibility to define additional item filters

Thanks for the help @TheMilek

"Only discounted products" criteria must be updated to use `offer.is_discount`

Hi @ddattee, Thank you for report this issue. You are right, actually it is impossible to retrieve the product list with the criteria `is_discount`. We need to find a way...

Use the admin path name variable to allow the prefix value to be changed

Can I have a review? @GSadee or @diimpp?

Use path_name parameter for admin prefix

@loevgaard done

Use path_name parameter for admin prefix

@loevgaard it's not linked to this PR, there are the same errors on master: https://github.com/Setono/SyliusFeedPlugin/actions/runs/7711190968 I don't have time to watch your build

Admin global search and filters not working

Hello @adimilea, It's a mistake. We did not updated the sql search queries when we have a custom entity product attribute. But a fix has just been merged (#23) and...