Chris Swithinbank

Results 478 comments of Chris Swithinbank

Nice work @OliverSpeir! Some quick thoughts: - with Astro, script tags are bundled into a single JS file, so in fact static imports don't usually cause _any_ additional network requests....

Looks like there's still a bug. Initial build for this branch succeeded, then when I re-ran the deployment with the same build cache, it failed.

Redeployed manually from the Vercel dashboard. Just triggered one again.

Seems to have failed again: https://vercel.com/astrodotbuild/docs/DVUyCuznbY7jLsaXChRui5LSxpwE

Looking good! https://vercel.com/astrodotbuild/docs/CPitQx2B7xJkUTiUKZvbvFUCypvA

Marking this as a draft until https://github.com/withastro/astro/pull/11170 is released.

Thanks for the issue! Yes, I noticed this too recently. As a workaround it is possible to set the `getSlug()` function manually and use `.webp` (here’s [an example](https://github.com/withastro/docs/blob/e523d91ef2b46d5f027bd57676f1c5137beeed6a/src/pages/open-graph/%5B...path%5D.ts#L22-L27)), but it...

Oh, you shouldn’t need a pnpm patch! In the example I linked, `getSlug()` is passed as an option to `astro-og-canvas`, which overrides the default one: ```js import { OGImageRoute }...

Hey @mattbrailsford — been a while since I worked on this, but IIRC the main reason for not doing this was to avoid the risk that things get stuck because...

Hmm, not sure what’s going on here. It could be a font naming issue, for example, I know that with Noto Sans, we specify `"Noto Sans"` but also additional variations...