Chris Swithinbank
Chris Swithinbank
Just took a quick look and, while do-able, will need a little re-architecting to achieve. Currently the system looks like this: 1. URLs are tested with a `matcher()` (basically a...
Thanks for the issue! I noticed this as an accessibility problem too: links without `href` are not focusable, so the play button can’t be reached with the keyboard. I think...
Update: have a fix on a local branch. Will open an upstream PR tomorrow.
Opened a PR here: https://github.com/paulirish/lite-youtube-embed/pull/177 Let’s see if we get a response and if not we can look to revert the progressive enhancement pattern in `astro-embed` or use my fork...
@jasikpark I think that’s unrelated — see #59 Depends a bit how you’re rendering the RSS feed I suspect.
Fixed in the latest release of `@astro-community/astro-embed-youtube` — [v0.5.3](https://github.com/delucis/astro-embed/releases/tag/%40astro-community%2Fastro-embed-youtube%400.5.3).
I haven’t heard of Rumble, but if there’s a good way to build an embed component a PR would be welcome. We have a [guide for how to add a...
> I have a working example but can't get it working in astro-embed Feel free to open a draft PR and I’ll try to see if I can help out...
Thanks for the issue @redneckrobot — was this with the YouTube or Vimeo component?
Closing this in the hope it’s been fixed in the meantime. If you could share a reproduction, I’d be happy to reopen and take a look.