Byron Hambly

Results 149 comments of Byron Hambly

I've seen this before, but couldn't narrow it down at the time :( It seemed to happen only over Tor, I don't think I ever had the issue when using...

It's possible upgrading libp2p could help with this, this thread has some useful info: https://github.com/libp2p/rust-libp2p/pull/3605 Unfortunately upgrading libp2p is a major task

hey thanks for the PR, i’ll only get a chance to review during the week

pushed a commit to fix the fmt. there is a test compilation error

breaking changes should be bumping the `protocolVersion` too, which means we also need some sort of integration test against old versions when releasing a new version

Thanks! Yes saw that, and just made this issue to track having some logic in the cli/asb regarding that version

@apoelstra I think they are run as part of [`test.sh`](https://github.com/ElementsProject/rust-elements/blob/master/contrib/test.sh#L24) ? or does your local CI not use that script

cool.. maybe a `postCheck` that calls `run-parts` ?

concept ACK - I don't ever want to think or bikeshed about formatting