xmr-btc-swap icon indicating copy to clipboard operation
xmr-btc-swap copied to clipboard

Use libp2p identify for compatibility issues

Open delta1 opened this issue 2 years ago • 3 comments

We should have the agentVersion available when identifying with peers. We can use this to work around compatibility issues - either by marking or hiding incompatible peers.

see #1184 and #1267

delta1 avatar Jan 08 '23 15:01 delta1

breaking changes should be bumping the protocolVersion too, which means we also need some sort of integration test against old versions when releasing a new version

delta1 avatar Jan 09 '23 08:01 delta1

Fyi I already made the agentVersion available with https://github.com/comit-network/xmr-btc-swap/commit/9e96ef64d3d5c6444dcf8cda92eba232186614e4

binarybaron avatar Jan 11 '23 11:01 binarybaron

Thanks! Yes saw that, and just made this issue to track having some logic in the cli/asb regarding that version

delta1 avatar Jan 11 '23 12:01 delta1