Byron Hambly

resolved conflicts, running CI

pushed clippy and minor fixes will review further soon

I think the RPC test needs to be in CI and modified before this can be merged. Since the tests need to run in serial, it might as well be...

> I think leaving the tests separated is fine to avoid waiting on one big slow test. I disagree, especially since they don't work. Conflicts need to be resolved to...

@yamabiiko: sorry, I seemed to remember it failed last time I tried it. Regardless, it's extremely inefficient since they must be run serially, and also doing the container setup and...

Please work on an accompanying test, you could use this one as a starting point https://github.com/comit-network/xmr-btc-swap/blob/master/swap/tests/alice_manually_punishes_after_bob_dead.rs

> Out of curiosity, why resolve on 0.24.1 instead of the most recent release (0.28)? looks like you’re referring to secp256k1, this PR is upgrading secp256kfun. as for the versions,...

> LGTM but have you completed a swap using the new CLI version and an old ASB version yet? no i have not

updated to include #1546 #1547

updated to include #1549 #1550