xmr-btc-swap icon indicating copy to clipboard operation
xmr-btc-swap copied to clipboard

Published 20 hours ago • verified publisher icon comit-network

Improve usability of refund

Open thenhnn opened this issue 11 months ago • 2 comments

User can try to refund even if it is no longer possible. We will show plain text error rather than ugly JSON error, see #674 for more info.

Fixes #683

thenhnn avatar Mar 06 '24 13:03 thenhnn

I'm not sure about fn cancel because it does error handling in proper way (as i understand), but logs it to tracing, rather than showing it to user.

thenhnn avatar Mar 06 '24 13:03 thenhnn

Please work on an accompanying test, you could use this one as a starting point

https://github.com/comit-network/xmr-btc-swap/blob/master/swap/tests/alice_manually_punishes_after_bob_dead.rs

delta1 avatar Mar 06 '24 13:03 delta1

sorry, can you unassign me? i'm a bit busy and i'm not sure if i can make this.

thenhnn avatar May 25 '24 18:05 thenhnn

sorry, can you unassign me? i'm a bit busy and i'm not sure if i can make this.

Sure thing. I'll leave this open as a starting point for someone else.

binarybaron avatar May 27 '24 08:05 binarybaron

Closing this in favour of https://github.com/comit-network/xmr-btc-swap/pull/1668

binarybaron avatar Jun 10 '24 16:06 binarybaron