Avi Deitcher
Avi Deitcher
I truly don't remember that part. 😁 I could see having an `err error` and a `done bool` property, not sure I would want much else. What is the `Manager`...
I thought about this a bit more over the last few days. I still am having a hard time seeing the benefit of a `ProgressManager` interface over just having a...
Good point there @shizhMSFT . I am trying hard to keep the abstract interface (is that redundant?) that goes to `Copy()` as simple as possible, while the implementation of the...
@shizhMSFT yes, this is pretty detailed. It is more advanced - but also more complex - than I had in mind. From the `Copy()` perspective, all I would think it...
Heh, crossed wires. I am reading your latest comments now.
Looking at your example, you didn't plumb it into `Copy()` or `Fetch()`, but you decorated the `desc`? What am I misunderstanding? That is a lot of extra overhead to do...
> A manager is required since Copy() deals with multiple descriptors but Fetch() and Push() only deal with one descriptor at a time. I don't think that changes anything. If...
Hold on a second. You are not decorating the _desc_, you are decorating the _reader_? ```go r, err := repo.Fetch(ctx, desc) if err != nil { tracker.Fail(err) return } defer...
So all you are doing is wrapping a `ReadCloser` with a `ReadCloser` that has the "let me call some function to report updates once in a while" logic inside it?...
That makes a _lot_ of sense. It is the canonical way of doing things like that in go. I still don't get how we would do that with `Copy()`, which,...