Avi Deitcher
Avi Deitcher
@mikem-zed @rene @milan-zededa any thoughts on [this comment](https://github.com/lf-edge/eve/issues/4322#issuecomment-2399845100), especially the part about halfway through it: > lib/firmware is 153MB. 202 lines in there, not going to post it all here....
Maybe I'll try next week to build pillar without any reflect and see what happens. Not sure about json marshalling. I don't think it depends on it, but not sure.
I just checked the source code for golang/go, same thing. I wish I could remember where it was I had the conversation about reflect and removing unused, and if it...
[Here](https://github.com/golang/go/blob/go1.22.3/src/cmd/link/internal/ld/deadcode.go#L129) is the part that strips things out unless reflect is used.
I spent quite some time digging more deeply. There is an excellent presentation - and pretty good tool - given by the author of [whydeadcode](https://github.com/aarzilli/whydeadcode) (links to slides and talk...
> So I guess at max we can save 3MB with solely this change Correct, but that isn't because of any general deadcode detection. It is because of anything directly...
Might be. I didn't think we changed any of that, but I can walk it through and look.
Oh I think it is. This isn't related to all of the build work, but the support we added for multi-arch build. Going to fix that right away.
> Is suffixing architecture to the user-specified tag name expected now? It is, until we can come up with a better way to do it. Docker engine does not (yet)...
> How about a type ProgressManager interface in CopyOptions? What does it look like? How is it better than a channel or a func? Maybe a practical example would help...