Roman Shtylman

Results 321 comments of Roman Shtylman

Pillarjs? Needs a good logo! Oh Yea.. Nothing to do with this issue hahahaha

@Methuselah96 Would you be open to a PR which removes these unsafe calls by converting the JSONTree and JSONNestedNode to function components and using hooks?

@Methuselah96 I looked at the types here and can't make sense of where this error comes from or what the intended behavior is. I did not change any of the...

Even if I updated JSONNestedNode to set a default for circularCache, that doesn't prevent the error. The issue is that JSONArrayNode props are of type `CircularPropsPassedThroughJSONNode` which extend `JSONNestedNodeCircularPropsPassedThroughJSONNode` which...

I've updated the typescript prop types to reflect allowing undefined.

@Methuselah96 anything else that I need to do on this PR before it can be merged?

Related: https://github.com/foxglove/studio/issues/4312

@tomy983 thanks for the issue report - could you share a bag file that will help us reproduce this issue. If you'd like to share privately you can email directly...

Had a chat and going to push this until after GA. This ticket is about selecting individual points in point clouds.