Vasilii Demidenok

Results 20 comments of Vasilii Demidenok

Example: ``` ./apps/antidote/priv/log_dump.erl _build/test/logs/[email protected]_13.28.39/dev1@fedora/antidote-data/0--0.LOG ``` ``` FILE: "_build/test/logs/[email protected]_13.28.39/dev1@fedora/antidote-data/0--0.LOG" INFO: [{name,log}, {file,"_build/test/logs/[email protected]_13.28.39/dev1@fedora/antidote-data/0--0.LOG"}, {type,halt}, {format,internal}, {size,infinity}, {items,0}, {owners,[{,false}]}, {users,0}, {mode,read_only}, {status,ok}, {node,log_dump@fedora}] LogId: [0] ------------------------------------------------------- NODE: dev1@fedora DC: {dev1@fedora,{1656,502120,505029}} |G:1|L:1|TX:1656502150192990-|OP:update| key =...

I suggest to get rid of checkouts directory: ``` diff --git a/_checkouts/gingko b/_checkouts/gingko deleted file mode 120000 index 71193e12..00000000 --- a/_checkouts/gingko +++ /dev/null @@ -1 +0,0 @@ -/Users/pandey/work/gingko/ \ No...

Starting from 9695e13ba0a1d223d9d2abdb75bcfab15cd354e7 all calls to logging_vnode should go to gingko_vnode, as that is a new replacement.

So I guess the proper fix for this would lead to non-compatible change as it also requires changes to soap_fault types. Any plans to fix this?

@deadtrickster Have you finished with that fix? Maybe create a pullrequest towards this repo, or https://github.com/willemdj/soap ?

@cmullaparthi What do you think?)

@cmullaparthi ping me if you want me to provide some tests regarding those callbacks.

@cmullaparthi Provided tests for the this functionality. Tests on 1.1.x cowboy branch pass fine. BTW Current cowboy2 integration seems to be broken. At least api that I checked here https://github.com/ninenines/cowboy/blob/2.0.0-pre.5/src/cowboy.erl...

Oh I see, it was broken since https://github.com/ninenines/cowboy/blob/2.0.0-pre.4/src/cowboy.erl