Deepthi Sigireddi
Deepthi Sigireddi
> I don't know how to rebuild/regenerate the vtctld2 bundle (make web_build is failing for me, something about sass i think but i didn't look too much at the output...
@ajm188 I suspect more changes are needed in flag.ts ``` public getArgs() { if (this.getStrValue() === '' || !this.positional) { return []; } if (this.namedPositional !== undefined) { if (this.getValue()...
@maxenglander your last commit needed to include changes to unit tests. It's good to run `make unit_test` locally before pushing changes. CI is a very expensive way to detect unit...
We need a better name for "Externally Reparent" - since we dropped `Reparent` from the other UIs and called it `Failover` instead.
I suspect the `gofmt` changes may be relics of the golang version issues you had last week. On a clean checkout of main, `gofmt` suggests no changes for me ```...
@joneug can you fix the DCO and force-push? We cannot accept any contributions without a sign-off.
https://github.com/vitessio/vitess/pull/9992#issuecomment-1080707290
What is the use case for explicit shard-targeting? Apologies if it is already documented in the tracking issue. I scanned it but didn't see a relevant section.
actually `unit_race` is failing. @vczyh can you run that locally and fix that? It looks related to this code change.
Of course it passes on this PR... You might want click re-run on Actions to try to get it to fail. I'm doing the first re-run now. https://github.com/vitessio/vitess/actions/runs/2821673131