Frances/shard actions

[notfelineit]

Description

This PR implements:

• [x] DeleteShard https://github.com/vitessio/vitess/issues/8732
• [ ] ReloadSchemaShard https://github.com/vitessio/vitess/issues/8723
• [ ] ExternallyReparent https://github.com/vitessio/vitess/issues/8728
• [ ] PlannedReparent https://github.com/vitessio/vitess/issues/8724
• [ ] EmergencyReparent https://github.com/vitessio/vitess/issues/8731

Delete Shard

Related Issue(s)

Checklist

• [ ] "Backport me!" label has been added if this change should be backported
• [ ] Tests were added or are not required
• [ ] Documentation was added or is not required

Deployment Notes

[vitess-bot[bot]]

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

• [x] Ensure that the Pull Request has a descriptive title.
• [ ] If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
• [ ] If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
• [ ] If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

• [ ] There should be at least one unit or end-to-end test.
• [x] The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

• [ ] There should be some code comments as to why things are implemented the way they are.

New/Existing features

• [x] Should be documented, either by modifying the existing documentation or creating new documentation.
• [x] New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• [ ] Protobuf changes should be wire-compatible.
• [ ] Changes to _vt tables and RPCs need to be backward compatible.
• [ ] vtctl command output order should be stable and awk-able.

[deepthi]

We need a better name for "Externally Reparent" - since we dropped Reparent from the other UIs and called it Failover instead.

[notfelineit]

@deepthi @iheanyi Thanks y'all! I'll address those comments now!

[notfelineit]

@deepthi I've renamed it to "External Failover":

[deepthi]

I suspect the gofmt changes may be relics of the golang version issues you had last week. On a clean checkout of main, gofmt suggests no changes for me

% git status
On branch main
Your branch is up to date with 'upstream/main'.

nothing to commit, working tree clean
% find . -name '*.go' -exec gofmt -s -w {} \;
% git status
On branch main
Your branch is up to date with 'upstream/main'.

nothing to commit, working tree clean
% go version
go version go1.18.5 darwin/arm64
% which gofmt
/Users/deepthi/.gvm/gos/go1.18.5/bin/gofmt
% go version -v ~/.gvm/gos/go1.18.5/bin/gofmt
/Users/deepthi/.gvm/gos/go1.18.5/bin/gofmt: go1.18.5

[notfelineit]

@deepthi interesting - I am definitely on the same go version:

➜  vitess git:(frances/shard-actions) go version
go version go1.18.5 darwin/amd64

btw this branch is branched off upstream/main too!