Deepika Udayagiri
Deepika Udayagiri
> I really like the current proposal. The logic is greatly simple and straightforward now. At least for me, the behavior also fits to what I as a user would...
@akurtakov Instead of calling the deprecated getVisibleLinesInViewport method, the line count can be computed inline within the caller, as I have access to the fTextWidget object. However, the limitation noted...
@jukzi : can you take a look at this when you have some time please?
@laeubi @jukzi : all the comments are incorporated, can you check now please. Thanks for your suggestions.
> @deepika-u I still think it is better fixed at the caller side than in this particular method, so in what cases can it really happen that it is called...
@laeubi > So can you share a stacktrace of the problematic call so we can better decide what would be the best place here? I tried myself running CTabItemTest and...
@laeubi On further anlaysis, i felt EditActionGroup.dispose() also needs to be updated. So adding this change too to make the fix complete. Now with the EditActionGroup.dispose() changes in place along...
> In the log I can only see errors about already disposed part / device but not any access from another thread? yes exactly now with these both file changes,...
@laeubi > The point is that we should not fix side-effects but the callers who call the method outside the Device thread so that callers stacktrace would be required here...