eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

Removal of deprecation details due to warning caused in #2268

Open deepika-u opened this issue 2 months ago • 4 comments

deepika-u avatar Nov 12 '25 09:11 deepika-u

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 13m 31s ⏱️ -23s  8 234 tests ±0   7 985 ✅ ±0  249 💤 ±0  0 ❌ ±0  23 622 runs  ±0  22 828 ✅ ±0  794 💤 ±0  0 ❌ ±0 

Results for commit a50012a6. ± Comparison against base commit 200996c0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 12 '25 10:11 github-actions[bot]

@deepika-u Have you looked into what would cause to not use this method in console? It is what I would rather see be done rather than this push/revert.

akurtakov avatar Nov 12 '25 11:11 akurtakov

@akurtakov Instead of calling the deprecated getVisibleLinesInViewport method, the line count can be computed inline within the caller, as I have access to the fTextWidget object. However, the limitation noted in the deprecation still applies - results may be inaccurate when the widget uses variable line heights. I will continue investigating potential approaches. Do you have any suggestions on how this could be achieved?

deepika-u avatar Nov 12 '25 15:11 deepika-u

I haven't found the time to look into it at all. It's the general approach how things should happen in this case that I pointed out.

akurtakov avatar Nov 12 '25 16:11 akurtakov