Nils Diefenbach

Results 96 comments of Nils Diefenbach

Go ahead, first come - first served :)

Yepp, you're right - they need fixing. I disagree on them being useless, however. Anyone submitting their PRs should have run tests before submitting, making sure their tests pass, and...

You're on the right track, yes! Have a look at https://github.com/Crypto-toolbox/bitex/blob/master/bitex/formatters/base.py There are examples for the expected outputs.

It should be indeed. Or the docs changes - It may be better to sort the data by quality. The thing is, `timestamp` is not always given, so some of...

`None` would be more appropriate IMO, since we actually do not receive any timestamp from the API. An empty string looks somewhat like a faulty parser. Otherwise, that's all correct.

> But I don't understand where do you configure how a single value of the array can be changed as discussed? You'd have to loop over `bids` and `asks` before...

1. What exactly do you mean by config file? 2. Shouldn't be an issue since they ideally only initialize once - so it's really a single request more on start...

Ah, now I got ya. I'm not a fan of the json format - however, you could merge the ini files into a single one, with sections for each API....

For mocking API Responses, see this SO thread: https://stackoverflow.com/a/28507806/5413116

@AndrewLCarpenter , thanks for the pointer! I have not heard of this, but it looks really neat! I'll check it out in detail. Thanks!