Nils Diefenbach

Results 96 comments of Nils Diefenbach

Congrats, you've encountered a perfect example for why I initially opted for dropping the formatter idea :'D I would define some sort of default value for data which is not...

>I liked the idea of the timestamp being inside the tuple returned from the formatter, so that everything needed is contained inside that tuple, but we can move the timestamp...

>Ok, then I suggest we at least use Decimal as intermediary step before providing the data as strings to the user, instead of stringifying a float. [...] That doesn't make...

`client_ts_iso8601` is cumbersome, but the general idea is good. perhaps, instead do this: add an attribute `received_at_dt` to `FormattedResponse`, which stores the aware `datetime` object, and a property as follows:...

It was my impression that `%-Y%m-%dT%H:%M:%S.%f+%z` creates this `2018-01-15T14:56:02.000+00:00` is that not ISO? If not, I leave the formatting to you then :D edit: I just saw I used a...

Hey @firepol , good thinking! The classes like `ETHBTCFormatter` were created for convenience, in order to have some commonly occurring pairs already provided as a formatter object. I like the...

Hey @andy-io , thanks for the contribution! As CoinExchange currently only offers a public API, I'm putting this on the backburner until we've implemented the other exchanges. However, if you...

Hey @Razorbob, Thanks for contributing! What version are you using ? I'll look into this as soon as I can. Cheers, Nils

@Razorbob , ok, to recap - it works on the 'v2' API but not v1 ? Or it doesnt work with either? Could you send me the code snippet you...

Hey @Razorbob, Running this (Bitex 1.2.1): ``` from bitex import Bitfinex c = Bitfinex(key, secret) print(c.balance()) ``` works without issue for me.