deelawn
deelawn
On second look, I think performance could be improved by rewriting the query to simply select COUNT(\*) from the same data source rather than select from a derived table; replace...
Any estimate as to when this will be implemented? For now I have to split out subfolders into separate collections in order to run them individually.
> > @ltzmaxwell Can you please check @deelawn's comments on this PR? 🙏 > > Updated 🙏 . I don't think that fixed it -- see this comment https://github.com/gnolang/gno/pull/1601#discussion_r1505134477
This is somewhat related to the issue #1091 which #1711 is meant to address. In that case, we don't want to enable shadowing native / builtin types. Perhaps we also...
How does it compare to https://github.com/gnolang/gno/blob/master/examples/gno.land/p/demo/maths/overflow.gno? Should we remove that from the demo packages if we are making it part of the stdlib? I think it makes sense for it...
Overflow protection seems like such a core feature of a blockchain that the package should be included our standard library, especially if they are used by other parts of the...
I think that, based on [this comment](https://github.com/gnolang/gno/blob/master/examples/gno.land/p/demo/maths/overflow.gno#L1-L6) in the package implementation, we should go with that code if we want to move it into the standard library. It includes a...
@ltzmaxwell can you resolve the conflicts with the main branch?
Thanks for fixing the type assertion issues @ltzmaxwell. I can see one more thing that should be done to make this solution complete. Now that we support aliasing pointer types,...
> I mostly reviewed ghverify so far and some related functions. I haven't gone through the entire source of the package; I'd like to have a better understanding of the...