DJ Gregor

Results 28 comments of DJ Gregor

FYI: there is an option on the Python Jaeger thrift exporter, `split_oversized_batches` to split batches that are too large: https://github.com/open-telemetry/opentelemetry-python/blob/main/exporter/opentelemetry-exporter-jaeger-thrift/src/opentelemetry/exporter/jaeger/thrift/send.py#L73

I started working on this in #1111.

See #2591 / #2592. I think this might cover what you are thinking.

Is anyone working on a PR for this change to the spec (or planning to work on one)? If not, I'm happy to work on a PR. I'm very new...

Is there anything special to the `.circleci/pyscripts` directory, or is that just where we put supporting Python scripts and libraries for Circle CI builds?

Do we have any standards on formatting/linting of Python code? If not, we might want to do something like run it through `black` and cleanup warnings from `pylint`. We could...

FYI: A number of jobs on this branch failed -- https://app.circleci.com/pipelines/github/OpenNMS/opennms?branch=mem%2Fjira%2Fnms-14459-smoke * https://app.circleci.com/pipelines/github/OpenNMS/opennms/22769/workflows/5395e023-0cf7-4343-8724-d238cf30b1c6/jobs/168629 * https://app.circleci.com/pipelines/github/OpenNMS/opennms/22769/workflows/5395e023-0cf7-4343-8724-d238cf30b1c6/jobs/168635 * https://app.circleci.com/pipelines/github/OpenNMS/opennms/22769/workflows/5395e023-0cf7-4343-8724-d238cf30b1c6/jobs/168625

Woohoo! Glad to see this got merged!

> This generally looks OK to me; what does it look like in `systemctl`? Do we need to make init calls to startup disable the progress bar? That was my...

> This. Generally, users will never run `bin/opennms start` by hand, they `systemctl start opennms`. @dino2gnt I did some testing on Ubuntu with systemd and made some improvements. I added...