Marat Sharafutdinov
Marat Sharafutdinov
@antifuchs are there any plans to resolve this? For instance Crossbeam has special configuration flag for such kind of problem: `crossbeam_no_atomic_64` (https://github.com/crossbeam-rs/crossbeam/issues/731). Maybe it is possible to implement similar flag...
@asvetlov are you going to resubmit this PR to python/cpython ? I hope it's not abandoned.
@heckad as reference [says](https://www.rabbitmq.com/amqp-0-9-1-reference.html#basic.nack): > A client publishing messages to a channel in confirm mode SHOULD be capable of accepting and somehow handling the Nack method. So you should retry...
@agronholm are any updates on this? Hope you'll find opportunity to fix it 🙏🏻
Is it possible to backport this to 1.4 branch?
@briansmith do you have plans to update "ring" dependency version?
Commit [e966a96](https://github.com/mosquito/aio-pika/pull/610/commits/e966a965d079129d224fe64c6b2bd92199c4accb) may be reverted in the future when https://github.com/gmr/pamqp/issues/51 will be released (if it will be merged).
@mosquito https://github.com/gmr/pamqp/pull/52 was merged and released within version 3.3.0. I think firstly aiormq should be upgraded to pamqp of this new version and after that I can remove commit https://github.com/mosquito/aio-pika/pull/610/commits/e966a965d079129d224fe64c6b2bd92199c4accb...
Close callback receives not only sender but exception too. Here you can see how it goes: https://github.com/mosquito/aio-pika/blob/4abca046d81656dc10de9fad8acbd654ced964db/aio_pika/connection.py#L86 https://github.com/mosquito/aio-pika/blob/4abca046d81656dc10de9fad8acbd654ced964db/aio_pika/channel.py#L205 But here I found it receives future with the exception set: https://github.com/mosquito/aio-pika/blob/4abca046d81656dc10de9fad8acbd654ced964db/aio_pika/robust_connection.py#L101-L104...
The bug seems to be fixed by this PR. Why not to merge it?