aio-pika icon indicating copy to clipboard operation
aio-pika copied to clipboard

Published 20 hours ago • verified publisher icon mosquito

Do not use deprecated datetime.utcnow and datetime.utcfromtimestamp

Open decaz opened this issue 1 year ago • 3 comments

This change can be breaking because timestamp of incoming message will now have timezone info (UTC by default).

Fixes #609.

decaz avatar Dec 28 '23 18:12 decaz

Coverage Status

coverage: 88.125% (+0.1%) from 88.024% when pulling f0c7a813b98d6534390aef2ea063eac9d38e0f6d on decaz:fix-deprecation-warnings into 8804f3ccf5fe5572c52fe7075767cd5faa6fbac5 on mosquito:master.

coveralls avatar Dec 28 '23 19:12 coveralls

Commit e966a96 may be reverted in the future when https://github.com/gmr/pamqp/issues/51 will be released (if it will be merged).

decaz avatar Dec 28 '23 19:12 decaz

@mosquito https://github.com/gmr/pamqp/pull/52 was merged and released within version 3.3.0. I think firstly aiormq should be upgraded to pamqp of this new version and after that I can remove commit https://github.com/mosquito/aio-pika/pull/610/commits/e966a965d079129d224fe64c6b2bd92199c4accb so this PR could be mergeable.

decaz avatar Jan 12 '24 21:01 decaz