dec05eba

Results 18 comments of dec05eba
trafficstars

It looks like that code you linked to is thread safe but not the version that sfml uses (see: https://github.com/SFML/SFML/blob/master/extlibs/headers/stb_image/stb_image.h#L410). I guess sfml just needs to update stb_image.h to fix...

Sure. The crash doesn't happen all the time so i'll keep the code running for 1 day or so and see if it crashes

I created a small program to do that now: [sfml-crash.tar.gz](https://github.com/SFML/SFML/files/5419377/sfml-crash.tar.gz) and compiled with g++ main.cpp -o test-sfml-crash -pthread /usr/local/lib/libsfml-graphics-d.so.2.5 and same place with printing error still crashes, but this time...

I tested changing sf::err to use thread_local variables instead of static and it doesn't crash anymore (with your branch). And actually, doing this change alone without updating stb_image.h also prevents...

This shouldn't be closed yet, #1712 doesn't fully fix this. thread_local needs to be added in sf::err as described above.

>If I'm not mistaken, C++11 guarantees thread safety for stdout, stderr, etc. in the sense that no corruption will occur due to multi-threaded access. However, it's still possible that unbuffered...

@Bromeon Confirmed that the crash is gone in this branch

> Also, while I was writing this message I noticed `NVFBC_TO_HW_ENCODER` interface type, which may be worth checking out (https://developer.nvidia.com/sites/default/files/akamai/designworks/docs/NVIDIA-Capture-SDK-FAQ.pdf, page 6, Q4 describes it as, in my understanding, that...

I'll take a look at it. I also use nvfbc is my application and it doesn't have this flickering problem (that I can see) so i'll see if i can...