Debdut Chakraborty comments

Results 90 comments of


                                            Debdut Chakraborty

feat: Add `membersByHighestRole` endpoints

following your description, this is then basically a filter right? I'm not understanding the connection between the description (filtering by `role` field) and the name of the endpoint `membersByHighestRole` -...

fix: show only relevant userInfoActions for mentioned non-members

Right. But I don't think you need all these endpoints. Membership is a subscription. So one endpoint should be sufficient, like `subscription.exists?uid=..&rid=...`. Furthermore, nobody can leave a dm, so a...

fix: show only relevant userInfoActions for mentioned non-members

https://github.com/RocketChat/Rocket.Chat/blob/ed451251a3abfd64b26c9bdc8d18e9b84754a1f3/apps/meteor/server/services/authorization/canAccessRoom.ts#L55-L62

fix: show only relevant userInfoActions for mentioned non-members

also idk if client caches the memberlist, might be a good idea to utilize if it does.

[FIX] Unable to use SigV4 with S3 Uploads

~**Do not merge yet**~

New message parser fails to render markdown-formatted links with underscores in the description

I guess that means the issue is fixed on the latest develop ;)

Usernames are shown instead of real names in reactions

Hey Toni, I'm aware of this exact issue and Henit's PR. I'm due a discussion with our eng lead (who'll be back tomorrow) on some further points. Atm I'm thinking...

[FIX] Unable to set idleTimeLimit for users

Forgot test 🙈

Masked Textbox for settings

@cuonghuunguyen Can I ask a PR? 🙈

docker compose up recreates running container that does not have their configs changed in docker-compose.yml

> I'm facing this issue in docker-compose 2.11.2. To reliably reproduce : > > **Compose file** > > ``` > version: '3.2' > services: > router: > image: httpd:2.4 >...