Rocket.Chat
Rocket.Chat copied to clipboard
[FIX] Unable to use SigV4 with S3 Uploads
putObject
requires a file-stream (Stream) when using SigV4; So, a passthrough stream object was causing the upload to fail.
This patch switches over to the upload method which handles the stream correctly.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
~Do not merge yet~
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 43.52%. Comparing base (
7a59b79
) to head (7e6fd98
). Report is 2848 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #27616 +/- ##
===========================================
+ Coverage 42.70% 43.52% +0.81%
===========================================
Files 839 812 -27
Lines 17694 17175 -519
Branches 1977 1902 -75
===========================================
- Hits 7557 7475 -82
+ Misses 9884 9448 -436
+ Partials 253 252 -1
Flag | Coverage Δ | |
---|---|---|
e2e | 43.52% <ø> (+0.81%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Looks like this PR is not ready to merge, because of the following issues:
- This PR has conflicts, please resolve them before merging
- This PR is missing the 'stat: QA assured' label
- This PR is not mergeable
- This PR is missing the required milestone or project
- This PR has an invalid title
Please fix the issues and try again
If you have any trouble, please check the PR guidelines
Looks like this PR is not ready to merge, because of the following issues:
- This PR has conflicts, please resolve them before merging
- This PR is missing the 'stat: QA assured' label
- This PR is not mergeable
- This PR is missing the required milestone or project
- This PR has an invalid title
Please fix the issues and try again
If you have any trouble, please check the PR guidelines