Debadree Chatterjee

Results 37 comments of Debadree Chatterjee

I guess this passes has been 1 week! 🚀 cc @nodejs/tsc

I think this should be directed towards the main branch

So the general process is we land changes onto the main branch of this repo and then changes are backported to the release lines you can read about it here...

Hello, @Dzieni I think this issue is solved if you pass a strategy while converting the stream from node stream something like: ```js randomWebStream = Readable.toWeb(randomNodeStream, { strategy: new CountQueuingStrategy({...

> I think this is a bug. The whole point of streams is to manage the flow of data. So something like a default highWatermark while doing `toWeb()`?

From what I understand the high watermark would be 65536 "chunks" since here https://github.com/nodejs/node/blob/132c383b1872d0114e00722fe0610745f7f09cab/lib/internal/webstreams/adapters.js#L424 we dont set any size function and by default the size function just returns 1 Ref:...

@lilsweetcaligula tbf even I am confused here would need deeper investigation 😅😅

Are any of these in progress right now? I would love to learn and contribute!

Implemented in: - `finished()` https://github.com/nodejs/node/commit/32254988ba7c0c0a68d8dfbc32430466370bf170 - `pipeline()` https://github.com/nodejs/node/commit/23effb255efe3eb0dc935e3a430d80b41ea1e660 - `addAbortSignal()` https://github.com/nodejs/node/commit/96c720e98f4ea80103a9d240ae8072190a226729 - `compose()` https://github.com/nodejs/node/commit/94e1f8f8e139680d1de0531d8aaf7f971cfaa953

Hello!! First of all thank you so much for your work on the proposal and these tests! I noticed there there are efforts to split parts of the pr and...