Debadree Chatterjee

Results 37 comments of Debadree Chatterjee

Updated the docs, just question from https://github.com/nodejs/node/pull/48395#issuecomment-1589977209 remains

friendly ping regards to this question https://github.com/nodejs/node/pull/48395#issuecomment-1589977209 @benjamingr 😅😄

Hey @benjamingr added the short circuit with toWeb() as you suggested used symbols to communicate whether the iterator prototype is original or polluted, PTAL if it makes sense! Thank You!

Does anyone know what this failure means: ``` "readable-streams/read-task-handling.window.js": { "fail": { "unexpected": [ "evaluation in WPTRunner.runJsTests()" ] } ``` seems to be failing in some systems so inclined to...

added skips for some browser-specific tests, please PTAL and re-approve 😅

Hey everyone pinging again just blocked on what should be dont for https://github.com/nodejs/node/pull/48395#pullrequestreview-1470701774 cc @mcollina @benjamingr maybe we could land this implementation and do the toWeb thing in a follow...

Hello everyone! I have reverted the change of toWeb for now (I shall do it in a follow up, since i was getting confused 😅) PTAL it seems ready to...

Faced something similar in the nodejs implementation too have described it here https://github.com/nodejs/node/pull/50126#issuecomment-1755961475 it weird that the for the reference implementation and deno the promises for start and cancel resolve...

My hunch is maybe we missed some promise transformations but I tried applying all the promise transformation methods used in the spec like uponPromise, etc. but didn't make a difference...

I tried updating the usage of Promise.resolve() -> new Promise(r => r(value)) for `setupWritableStreamDefaultController` that resolves the present test cases but breaks another new one `readable.cancel() and a parallel writable.close()...