Results 9 comments of dearfl

@c8hunderscore it maybe a little bit late, but you could apply this patch to fix this link error. https://gist.github.com/dearfl/f125dfc35e7114e9e5080d8bfb5aae3a

I would approciate fix length list (like mac address, tuple is just messy), however I believe fixed length array and dynamic length array would be very different from the ABI...

> We can only assign issues to people who have commented on the issue (I guess a github limitation to prevent spam?) Not sure if there's a workaround but maybe...

> Thanks for contributing! A few tests for this behavior would make us confident it works really well. > > Could you add some tests in the lsp_interaction folder where...

> could you paste the test failure? it should show the messages back/forth. ``` running 1 test client--->server {"id":1,"method":"initialize","params":{"capabilities":{"textDocument":{"publishDiagnostics":{"codeDescriptionSupport":true,"dataSupport":true,"relatedInformation":true,"tagSupport":{"valueSet":[1,2]},"versionSupport":true}},"workspace":{"configuration":true}},"clientInfo":{"name":"debug"},"processId":64851,"rootPath":"/","trace":"verbose"}} clientserver {"method":"initialized","params":{}} Reading messages DEBUG Running with 3 threads (5 MiB...

> > > could you paste the test failure? it should show the messages back/forth. > > > > > > ``` > > running 1 test > > client--->server...

> @dearfl it looks like a bunch of tests are failing. would you be able to investigate this? Sorry, I can't figure out why this test fails, could use some...

> looks like a deadlock! I think we need to drop the lock on version_info in text_document_did_change before calling validate_in_memory_and_commit_if_possible. otherwise, both calls will be fighting for the lock. Okay,...