dearchap

Results 201 comments of dearchap

@FGYFFFF Without unit tests we cannot approve this PR since this is a behavioral change. If this is expected behaviour this needs to be in a unit test so that...

@icholy lets leave it as it is. Thanks

@jtagcat Love your effort. Please make sure to add unit tests. In fact I would write the test code first and then keep coding !!!!!

@meatballhat That should be fine. @ipostelnik Are you up to resolve the conflicts ?

@icholy This would be nice, are you willing to submit a PR ?

I dont think this is a good idea. Its not that the implemented is bad or anything, the problem is that so many users are already using Flag interface as...

@jalavosus I'm closing this as this is not the direction we want to go with Flag interface right now. Please consider contributing this to v3 which is ongoing. Thank you

v1 to v2 is expected to have breaking changes.

@nkuba Can you rebase your changes with latest ?

bump On Sat, Aug 28, 2021 at 12:07 PM stale[bot] ***@***.***> wrote: > Closed #1261 . > > — > You are receiving this because you authored the thread. >...