Dean Karn

Results 186 comments of Dean Karn

> I propose we build out the socket validations for each type one by one. Once we are confident we have considered all cases we can debate about if we...

By all means @kitosforos , PR's are always welcome

I have not. I have been so busy I haven’t had time to do much of anything with my open source work lately.

@puellanivis thanks for reporting, would you be able to make a PR to fix :)

@puellanivis I’m ok with a fix that might not be compatible as it seems like a bug. It doesn’t even have to be a regex. Looking forward to anything you...

@puellanivis any follow-up proposed solution here?

Thanks @puellanivis thats looks great! I’m totally fine with keeping it separate as long as you don’t mind if I try to bring it into the core of this lib...

Awesome thanks!

Thanks for reporting @BrianLeishman , definitely shouldn't have done that. PR's to fix are welcome, I will try to look at it though.

@1379 sounds like a great enhancement for the next version of the lib, but unfortunately right now is a breaking change.