Skyler Hawthorne comments

Results 196 comments of


                                            Skyler Hawthorne

Crash after using save selection -> smart tab on a new line

Hmm, that's strange, I'll look into this. At first glance, I'm not sure how smart tab could be involved here; all it's doing is moving the cursor. I wouldn't expect...

feat(command): select all siblings and children

> after trying this out for a bit I think `select_all_children` would benefit a lot from only selecting children that are actually contained in the selection. Hmm, but in this...

feat(command): select all siblings and children

Just added `select_all_children_in_selection` that only selects if all resulting ranges are contained within the starting selection.

feat(command): select all siblings and children

Sounds good, will do

feat(command): select all siblings and children

Ok I've rebased and changed all the motions to use the new in-crate `TreeCursor` instead of the tree-sitter API directly. This required adding a child iterator in the TreeCursor module.

feat(command): select all siblings and children

Good suggestions, I took care of them.

Inconsistent quote matching behaviour with multiple selections

Yeah this is unfortunately behaving as designed currently. It intentionally does not auto pair when the preceding char is an alphanumeric in order to handle apostrophes in prose. Using TS...

Inconsistent quote matching behaviour with multiple selections

The problem with TS is that it works very inconsistently depending upon whether it can recognize the node you're starting to type when it's incomplete. Specifying to ignore auto pairs...

Inconsistent quote matching behaviour with multiple selections

Oh interesting. Yeah agreed, I think it makes sense to use TS where it can concretely improve the situation, like comments. But yeah, I share your fear that we can't...

Properly handle case where last character in a cancelled command begins a new command

> I think this might be a bug with the integration testing Framework. It seems that `\n\n` gets turned into `\n` somehow. > > CC @dead10ck This is actually intentional,...