Skyler Hawthorne

Results 196 comments of Skyler Hawthorne
trafficstars

The issue of the auto format changing the revision number is proving to be kind of a tough nut to crack. I tried making it work by having the auto...

Ok @archseer, I managed to get something working that waits for auto format and save to finish on `write-quit` It turns the callback type into an enum to allow for...

Nice, good catch @the-mikedavis! This makes sense. It looks like the format callback needs the view to apply the LSP edits, but the [shutdown (1)](https://github.com/helix-editor/helix/blob/cb54ed3331b4449b5372a30255ef59c06d735283/helix-term/src/application.rs#L272) [sequence(2)](https://github.com/helix-editor/helix/blob/cb54ed3331b4449b5372a30255ef59c06d735283/helix-view/src/editor.rs#L1109) is [initiated by closing...

Ok, I think I fixed it

Thanks for taking a look @pickfire ! Would you be willing to dogfood this build for a bit of time to see if you notice any issues in practice? If...

I rebased and incorporated a fix with the same effect as #3684. I also did a little refactoring to be able to write a regression test for it; it is...

I have to agree with @the-mikedavis here, I don't think this belongs in core. The whole editing paradigm is centered around interactive text replacement, not batch operations. With the exception...

Closing in favor of #3901. Thanks for your report!

Just curious, what is the use case for this?

@antoyo This definitely looks like there's an issue with your LSP. However, this does suggest that in general, it would be good to add the ability to add timeouts to...