Yiyu He

Results 82 comments of Yiyu He

> This feels like I'm missing something though. @dead-horse can you confirm on your end? Yep, you should change the benchmark test file to `new Koa({ asyncLocalStorage: true })` to...

All these pending PRs are not so emergency to me, so if anyone has any thoughts or some feature / refactor required, post in the issue to help us decide...

As a backend framework, reduce package size is at a lower priority. :)

-0 for me, I'd not like to add a duplicate API, and most of users are already used to set header with `response.set(headers)`

all these events can implemented in `application.handleRequest`: ```js handleRequest(ctx, fnMiddleware) { const res = ctx.res; res.statusCode = 404; const onerror = err => ctx.onerror(err); const handleResponse = () => {...

need test cases for this feature

I'm ok to remove the 'ENOENT' case, but it would be a breaking change.

Is there a specific usage scenario that requires clone ctx?

https://github.com/jshttp/statuses/blob/master/HISTORY.md#200--2020-04-19 looks like this upgrade contains incompatible changes

业务的错误码需求和框架的错误码需求不一样,这个只用考虑框架的就可以了。