David Cramer

Results 236 comments of David Cramer

@jrocketfingers should be mostly easy as you only need to hook into a common point for catching errors. Outside of that, the Flask integration is probably the best to imitate.

(just to prevent anyone from suggesting it, mix-in's and any other complex OO behavior are not a solution to this problem)

Should we really allow them to _stay_ NULL? My concerns around that are you wont be able to access foo.key_name, you'd have to say if foo and foo.key_name in many...

@astilla Do you happen to know what the $code is used for in PHP internally? The code in our APIError is definitely not intended to represent anything more than what...

My feedback is all stylistic though I think the approach may not be very correct. This is making the assumption that there's a 64 bit integer.

Both of the points are good:) We'll be revisiting the interfaces.json very soon (as we update our plugins), so I'll keep this open for when we address that.

Going to discuss this over internally, as right now query types are sort of a hack. The current interface.json implementation is actually able to be auto generated, and we'll need...

5.3 might have actually been a guess. Will try to review and confirm. Neat tool :)

This seems to also have affected .get() (which before i had to do .get()['fields'] on) (I do note the reference in the changelog, but the docstrings/code still seem to allow...

A few problems right now: 1. sidebar needs fixed/scrollable 2. logout/settings icons ideally go at bottom of sidebar 3. footer needs pushed at least all the way to the bottom...