disqus-php icon indicating copy to clipboard operation
disqus-php copied to clipboard

Acceptance of query types in required arguments

Open JustAdam opened this issue 14 years ago • 3 comments

So now you can use:

$data = array('forum' => 'forum_name', 'thread:ident' => 'ident');

json configuration feels a little clunky, but does its job.

"details": { "required": [ "thread" ], "query_type": { "requires": "forum", "insteadof": "thread", "with_either": ["thread:ident", "thread:link" ] }, "method": "GET", "formats": [ "json", "jsonp" ] },

I have only updated the configuration for the threads commands (not sure if anything else is missing).

JustAdam avatar Apr 08 '11 11:04 JustAdam

Going to discuss this over internally, as right now query types are sort of a hack. The current interface.json implementation is actually able to be auto generated, and we'll need to add support for query types proper so that they can be included in that to do a release.

dcramer avatar Apr 11 '11 19:04 dcramer

Yeah, I had to hack it to do this as well. My hack is a little less involved.

brianlmoon avatar Oct 15 '11 02:10 brianlmoon

I think that last commit should probably of been patched against a fresh fork ... let me know if you need it done.

JustAdam avatar Nov 04 '11 12:11 JustAdam