Damian C. Rossney
Damian C. Rossney
@kyleplump @cllns . . . and concurrency has entered the room. :scream: I am out of my depth on that one. Not sure if having the two processes mucking with...
@cllns @kyleplump I want to keep expressing my position, by I am sensitive to the fact that written communication can often sound more contentious than it is intended to sound....
This is my *last* comment on eager vs. lazy. I *swear*. :roll_eyes: If we are calling our startup time "slow," I would ask, in comparison to what? It's not really...
On a separate note, would you believe that this video was in my watch queue and came up this morning? I play conference talk videos while I do certain mindless...
@adam12 Thanks! We considered using a search algorithm like that, but in addition to the speed issue, you would have to maintain a parallel stack with the params collected on-the-fly...
Following is a discussion of the two tests currently broken by the proposed changes. ## First Broken Test The first broken test is [here](https://github.com/hanami/router/blob/e9c15474ec182a1094d933160c6635e7c0afe63c/spec/integration/hanami/router/recognition_spec.rb#L572-L584), in `integration/hanami/router/recognition_spec.rb`. ```ruby describe "relative variable...
I see that the CI build is failing at the RSpec step, before any tests are run. I don't think this is caused by anything in this pull request. It...
Let us know if you would like to discuss at all. Questions and explanations might be faster that way. Thanks!
Thank you, Tim! I'd like to confer with @kyleplump before replying. We should get back to you shortly!
I spoke to @kyleplump before implementing the following. ## Changes to tests - We deleted the failing test from recognition_spec for the reasons discussed. - I thought I disagreed with...