Damian C. Rossney

> This code below is really hard for me to parse. Is there a way to simplify it? return unless split iterate break false. Could we just iterate over the...

This seems like a good time to pause and wait for @timriley's input. I believe that the results so far show that this is a viable path. It's faster than...

## Comments following the 2.3 release I was glad to see @kyleplump's performance fix get merged. In light of that and the 2.3 release, I thought this would be a...

This makes sense and was probably foreseeable. The previous version created the MM matchers ahead of time. I guess with a forking server, this makes the most sense: longer start-up,...

Postponing object creation in leaves is what was causing the problem: it meant creating a Mustermann matchers each time we had a potential route match. Kyle's fix moves that cost...

@kyleplump Thank you for continuing to look into this! I've been swamped on my end through the holidays. ## Optimizing Hanami Router 2.2 Your switch from RegEx to string splitting...

@cllns These are some interesting ideas for sure. My initial feeling is that this would be a case of premature optimization. I don't know how many apps there are out...

@kyleplump I'm in favor of polishing this PR up and merging it to fix the problem. Then we can experiment with further changes at our leisure. Let me know when...

Thank you for this @kyleplump! I really appreciate the way that you zeroed in on the performance issues introduced by 2.2. I believe that the performance of the router "in...

@cllns @kyleplump I feel strongly that adding further complexity here falls in the category of premature optimization. We are discussing significant changes based solely on a benchmarking tool that may...