David Coudert
David Coudert
Please rebase this branch on last beta. I will then review it.
try to change ```diff Sage example in ./lp.tex, line 681:: - sage: for e in g.edges(sort=True, labels = False): p.add_constraint( f[e]
I'm not in favor of such change. Indeed, it would require extra work in add/delete vertex/edge methods, and we try to make these critical methods as efficient as possible. I...
Most of our graphs generators `graphs.` return mutable graphs, and these graphs are names (e.g., Petersen graph). I don't think it is a good idea to force the generators to...
This can certainly be done, but it's a significant amount of work since we have hundreds of generators...
As I said in https://github.com/sagemath/sage/issues/38768#issuecomment-2399473334, I'm not in favor of such change that may slowdown many methods for a very small benefit.
@tscrim, do you know why the CI is not running for this PR ? it would be useful to finalize the review. I think the code is ok now.
What's the purpose of this last commit ? why is method `matching` in this PR ?
Methods `matching` and `is_factor_critical` have been moved to `src/sage/graphs/matching.py` in #38218. So you should not put them back to `src/sage/graphs/graph.py`.
> Can you be more specific about the 80 column mode? For what comments? These on GitHub or in the actual code? Sorry, this is my first time contributing. In...