David Coudert
David Coudert
The current proposal is to make `acyclic_orientations` return a digraph with properly directed edges #38757 What should be done in `.random_orientation()` ? We could also consider `strong_orientations_iterator` (which could be...
In #38809, we move all remaining orientation methods to file `orientations.py`. This should ease the maintenance and harmonisation of these methods.
Check `src/sage/graphs/bipartite_graph.py`.
The `*` in the list of parameters means that the parameters placed after the `*` must be explicitly named. ```py sage: def foo(a=1, b=2, *, c=3): ....: return a +...
Now that we have this class, what happens if I add/remove a vertex or an edge ? You should certainly adapt methods modifying the graph to ensure that a modified...
This PR is already very large. What I suggest is: - add a TODO block in the description of the module with the list of methods to be added. -...
> Shall the method `get_matching()` be named `matching()` in order to overwrite the method `matching()` as it will take less complexity since we already have a perfect matching in `self._matching`?...
> Hi, I have identified some more methods that are to be overwritten. The list goes as follows: > ... > * `bisubdivide_edge()`: The resulting graph shall be matching covered....
for the first issue, it's best if you can add doctests to avoid the warnings. For the second issue, I don't know how to fix that. Have you checked how...
I'm turning back this PR to needs work to let you some time to fix the issues.