Dominic Cocchiarella

Results 6 comments of Dominic Cocchiarella

This looks good to me, but will need conflicts resolved. @nbwar can you resolve conflicts and then I can approve/merge?

I think a nice way to do this would be to use the new ref forwarding api, use the same ref name for all components, and add tests to ensure...

I reached out to the Radium folks to see if they might be working toward fixing this. We'll see what they say and go from there. https://github.com/FormidableLabs/radium/issues/626

First portion of this fixed in https://github.com/instacart/Snacks/pull/220 We still need an explicit test for this before the publish step

Current known issues in IE11: - ~CSS Grid use~ (fixed with https://github.com/instacart/Snacks/pull/75) - `String.fromCodePoint` use in `Icon` component ( will be solve by move to `SVGIcon`) - `Array.includes` use in...

@wfro - Can you pick this one back up when you get some time? Looks like we should also add tests for these utils :)