Daniel Cloud

Results 37 comments of Daniel Cloud

I completely understand! I wanted to make note of this since I ran across it and it seemed like a group of issues around SQL copy commands could indicate some...

Closing in favor of https://github.com/department-of-veterans-affairs/va.gov-team/issues/86939

Per [Google](https://developer.chrome.com/docs/css-ui/css-text-wrap-balance): > Without text-wrap: balance; designers, content editors and publishers have [few tools](https://developer.mozilla.org/docs/Web/CSS/CSS_Text/Wrapping_Text) to change the way lines are balanced.. The best options available being to use [](https://developer.mozilla.org/docs/Web/HTML/Element/wbr) or...

Added context concerning identity checks: > Re: identity proofing policies, we have several in place (and more on the way with new NIST guidance). The only thing that’s important really...

[Saving preferred_name or gender_identity](https://github.com/department-of-veterans-affairs/vets-api/blob/b432aca178a346817ba400f0c56014db28070c9b/lib/va_profile/demographics/service.rb#L48-L73) in `lib/va_profile/demographics/service.rb` [A post_or_put_data method](https://github.com/department-of-veterans-affairs/vets-api/blob/b432aca178a346817ba400f0c56014db28070c9b/lib/va_profile/contact_information/service.rb#L300) gets used in various places in `lib/va_profile/contact_information/service.rb`

For NoK/EC, the fetching of said data is handled via `lib/va_profile/profile/v3/service.rb` where a method requests the `healthBenefit` bioPath

The in-progress `lib/va_profile/profile_information/service.rb`, which appears to be an alternative to `lib/va_profile/profile/v3/service.rb`, might affect how we submit updates for "associated persons"

Examples of VAProfile::Service implementations performing post/put operations, e.g. `perform(:post`: ``` lib/va_profile/military_personnel/service.rb- with_monitoring do lib/va_profile/military_personnel/service.rb- edipi_present! lib/va_profile/military_personnel/service.rb- lib/va_profile/military_personnel/service.rb: response = perform(:post, identity_path, VAProfile::Models::ServiceHistory.in_json) lib/va_profile/military_personnel/service.rb- lib/va_profile/military_personnel/service.rb- ServiceHistoryResponse.from(@current_user, response) lib/va_profile/military_personnel/service.rb- end -- lib/va_profile/veteran_status/service.rb-...

With regards to updates that would get cached and also sent to VA Profile: [lib/va_profile/contact_information/service.rb#L238-L244](https://github.com/department-of-veterans-affairs/vets-api/blob/2785e1bc834898977e890e3398ed4c10413f31fb/lib/va_profile/contact_information/service.rb#L238-L244) shows how information is pulled from the redis cache, and the model's put or post...

As an aside, the use of `public_send` reminds me of `objc_msgSend`, the message dispatch mechanism in Objective-C. The Python equivalent would be `getattr(obj, 'methodname')(*args)`. Back to the code at hand,...