Daco Harkes

Results 140 issues of Daco Harkes

Support for FFI calls with `@Native external` functions through Native assets on MacOS and iOS. For more info see: * https://github.com/flutter/flutter/issues/129757 ## Pre-launch Checklist - [x] I read the [Contributor...

platform-ios
tool
platform-mac

There are new test failures on [[cfe] Add test for issue 53539...[cfe] Add test for issue 52542](https://github.com/dart-lang/sdk/compare/e15806ae42f5542236997b5447d9836519ac04d0~...1807debf84f9cc5f6381cc0a5a1d82b4e5ce281f). The tests ``` standalone/dwarf_stack_trace_invisible_functions_test RuntimeError (expected Pass) ``` are failing on configurations ```...

area-vm
P3
gardening
triaged

There are new test failures on [Use the test file to check for navigation results....[analysis_server] Fix timeout in LSP-over-Legacy macro integration tests](https://github.com/dart-lang/sdk/compare/1e11807735052984c9838a7af72a95c8fb2f78aa~...5394052641e4b9c07713b5c1eea66dd2897c8bac). The tests ``` vm/dart/devirtualization_during_inlining_il_test Crash (expected Pass) ```...

area-vm
gardening
P4

Currently, calling a `NativeCallable.listener` from a `NativeFinalizer` callback hits an assert: ``` ../../runtime/vm/runtime_entry.cc: 4040: error: expected: current_thread->execution_state() == Thread::kThreadInNative ``` https://github.com/dart-lang/sdk/blob/1e0223e6d839255d18c8940a083482237f5f9318/runtime/vm/runtime_entry.cc#L4037-L4043 The assumption is that if we have a current...

area-vm
P2
library-ffi

Some or `close`/`release` functions have a different signature. If such signature requires extra parameters being passed in, such functions can be wrapped in a C function that takes a pointer...

area-vm
area-documentation
library-ffi

## Change intent (edit: Updated 2024-01-24 to reflect use of the `hook/` toplevel directory.) A package toplevel `hook/` directory will be reserved for scripts run by the Dart and Flutter...

area-sdk
breaking-change-request
enhancement-breaking-change
breaking-change-approved

`Pointer`s can be converted into external `TypedData` with the `asTypedList`. When sending messages to other isolates: * `Pointer`s are simply an address sent to another isolate. * external `TypedData`s have...

area-vm
type-enhancement
library-ffi

https://github.com/dart-lang/sdk/blob/ab09f99638af8b50c2b8700cd6bd07b9e89f6337/pkg/vm/lib/transformations/ffi/common.dart#L913-L928 This pattern of checking for whether something is backed by a Pointer, and doing pointer arithmetic if it is a pointer and a typed data view if it is...

area-vm
type-performance
library-ffi
triaged

``` $ out/DebugX64/dart --reload-every=4 tests/ffi/structs_test.dart kernel-service: Error: Unhandled exception: Bad state: No element #0 Iterable.first (dart:core/iterable.dart:643:7) #1 MappedIterable.first (dart:_internal/iterable.dart:382:31) #2 lookupOrBuildNewIncrementalCompiler (file:///usr/local/google/home/dacoharkes/dart-sdk/sdk/pkg/vm/bin/kernel_service.dart:463:45) #3 _processLoadRequest (file:///usr/local/google/home/dacoharkes/dart-sdk/sdk/pkg/vm/bin/kernel_service.dart:872:22) #4 _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12) ``` None...

area-vm
type-enhancement
P4
triaged

`elementAt` has been deprecated as of Dart 3.3 and should be replaced by `operator +`. https://github.com/dart-windows/win32/blob/a78ff108fbf54927b0334c1bab8f15526c24cbf8/lib/src/com/iapplicationactivationmanager.dart#L46 Valid SDK bound for using `operator +`: `"version:3.3.0-279.1.beta"`.