Daco Harkes

[jnigen] Document what version of Java to use and how to use the right one.

4

``` Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8 Exception in thread "main" java.lang.RuntimeException: java.lang.IllegalArgumentException: Unsupported class file major version 65 at com.github.dart_lang.jnigen.apisummarizer.util.ExceptionUtil.wrapCheckedException(ExceptionUtil.java:22) at com.github.dart_lang.jnigen.apisummarizer.disasm.AsmSummarizer.run(AsmSummarizer.java:21) at com.github.dart_lang.jnigen.apisummarizer.Main.main(Main.java:129) Caused by: java.lang.IllegalArgumentException: Unsupported class file major...

[native_assets_builder] How to deal with `NativeCodeAsset`s with conflicting install names and conflicting file names

1

**It seems that renaming dylibs is non-trivial on some OSes. So, we might want to make it an error to create dylibs with the same names. Either within one hook...

[dartdoc] The Dartdoc does not show `MallocAllocator` and `CallocAllocator`

1

The Dartdoc does not show `MallocAllocator` and `CallocAllocator`. https://pub.dev/documentation/ffi/latest/ffi/calloc-constant.html This is because we're not exporting these classes. https://github.com/dart-lang/ffi/blob/c926657618443ff4821411ede01684096b503f84/lib/ffi.dart#L5C50-L5C50 Thanks @tvolkert for reporting!

Currently FFIgen uses `dart:io` directly. This forces our FFIgenPad prototype to use [IOOverrides](https://api.flutter.dev/flutter/dart-io/IOOverrides-class.html). If we were to use `package:file`, we could potentially wire up all File reads and writes using...

[native_assets_cli] Sharing work between build hooks

4

Build hooks are per OS/arch. However, if assets are identical across multiple invocations, and the work to produce those assets is non-trivial, such work should be shared. Examples: * Data...

test pkgs/native_assets_builder/test/build_runner/link_test.dart fails on MacOS

2

The following fixes the test suite for MacOS: ```dart test('treeshaking assets using CLinker', timeout: longTimeout, skip: Platform.isMacOS || Platform.isWindows, () async { ``` @mosuem are we not running this test...

[native_assets_cli] Unify metadata and assets

4

We currently have 3 types of output of a build hook: * assets (for bundling) * assets (for link hooks) * metadata (for other build hooks) The most common use...

[native_assets_cli][native_assets_builder] Hot reload and hot restart

8

Whether hot reload and hot restart can be supported depends on the asset type. - For bundled native code, I expect us to be able to support hot restart for...

[native_assets_builder] Purge old directories

3

The native assets builder creates directories in the form of `.dart_tool/native_assets_builder/`. These directories should be purged at some point: https://github.com/dart-lang/native/blob/4c5fca965acecc0256489c9b0398518629cb9045/pkgs/native_assets_builder/lib/src/build_runner/build_runner.dart#L255 Possible purging strategy: * `touch` the `config.json` (or a `last_read.json`)...

[native_toolchain_c] Changes to header files should be added to the dependencies

3

The CBuilder lists the C sources, but not the header files. https://github.com/dart-lang/native/blob/952da66a77c09872816227f5313273d51a8f4ba5/pkgs/native_assets_cli/example/build/native_add_library/hook/build.dart#L12-L19 This means the headers are not added to the dependencies. Which means that any changes to the header...