Daco Harkes

Results 574 comments of Daco Harkes

Thanks for the digging @liamappelbe! 🙏 Ah, that's a "feature". We only include dev dependencies for `dart test`, and we "optimize" the hooks we run for `dart run` to only...

> Solution A Helicopter view: With the fact that we have objects at runtime representing the type, it makes sense that we would need functions such as least upper bound...

Notes from discussion w @mosuem @mkustermann @liamappelbe: * import library: have `hook` in the name. `package:data_assets/hook.dart` * (The public API may not have to expose a class, however this only...

> So a +1 to `input.code?.output.assets` from me! 😆 Maybe we should have `HookApi hookApi` * `hookApi.code` (nullable, only non-null if `hookApi.input.buildAssetTypes` contains `code`) * `hookApi.code!.input.config` * `hookApi.code!.input.assets` (link input)...

Places to start looking to address this issue: PR that introduced the template: https://github.com/flutter/flutter/pull/130494/files * template files: https://github.com/flutter/flutter/tree/master/packages/flutter_tools/templates/package_ffi * create command using the templates: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/commands/create.dart * unit test: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/commands.shard/permeable/create_test.dart *...

> It doesn't seem like the ability to create ffi_packages is enabled. ffi plugin creation works just fine. Why is this? and how can I activate it? Swap to `flutter...

>> Nevermind, I found the answer [here](https://github.com/flutter/flutter/blob/master/docs/tool/README.md) > > locally commit your tool change in git and the tool will be rebuilt from Dart sources I often forget to commit...

> Finished working on C++ Feel free to submit as a separate PR before adding Rust support. > Now working on the rust example > > It seems that implementing...

Maybe the right solution is to have a pluggable template system? Then we could add and maintain those templates in `package:native_toolchain_c` (which also does C++), `package:native_toolchain_go`, and `package:native_toolchain_rust`. Then the...

> > I'm not entirely sure what the maintenance burden of rolling the Go and Rust toolchains via DEPS would be. If I see it's going to be as simple...