Daco Harkes

Results 171 comments of Daco Harkes

> I'm not sure I understand where you'd need a try catch You should not catch it, but fix the application instead. (Only exceptions should be caught, not errors.) I...

> This SGTM @dnfield do you prefer (a) or (c) for returning errors? Do you have calls that currently return errors?

Background: * https://github.com/dart-lang/language/blob/spec_update_views_aug22/working/1426-extension-types/feature-specification-views.md

> most of the APIs are based on the static type. Correct, we migrated almost everything to extension methods. I see `elementAt` is still a method, but it is documented...

cc @athomas @whesse I'd really like an auto-bisect button in the Results Feed for bisecting a range of 18 commits w.r.t. a single test that changed status.

@rmacnak-google, 8c577c420c43f5fa4af3f077d8715b64d4dfb0c5 causes an MSAN error, PTAL.

Cool project @terrier989! /cc @sjindel-google

> given that Dart does not have variadic functions We _could_ support variadic functions with a List as argument in the Dart signature, if we really wanted to, but I'm...

> > > given that Dart does not have variadic functions > > > > > > We _could_ support variadic functions with a List as argument in the Dart...

In order to distinguish the varargs calling convention from the non varargs calling convention in `dart:ffi`, we need to indicate that somewhere. We have some options of doing this: 1....