Daco Harkes

Results 171 comments of Daco Harkes

> I see that the [CL](https://dart-review.googlesource.com/c/sdk/+/346380) was reverted due to this issue. I plan to prepare a PR for the migration and publish a new version today. No hurry. There...

I noticed the same thing. Actually the quick fix does not work for me, as the paper-item will grow too. Does the paper-item not expect to have a link inside?...

That works like a charm, I actually moved it up till the menu-item. ``` core-menu.fixlinkpadding paper-item::shadow .button-content{ padding:0; } core-menu.fixlinkpadding paper-item>a{ padding: 0.8em 0.3em; } ```

No hurry, there are other reasons why we need to postpone the removal of `elementAt`.

These are the tree biggest ones: * https://github.com/dart-lang/sdk/blob/main/tests/ffi/function_callbacks_structs_by_value_generated_test.dart * https://github.com/dart-lang/sdk/blob/main/tests/ffi/function_structs_by_value_generated_args_leaf_test.dart * https://github.com/dart-lang/sdk/blob/main/tests/ffi/function_structs_by_value_generated_args_native_leaf_test.dart

Awesome! Thanks @munificent! ❤️

> This is (more or less) intentional. It naturally falls out of how `=>` works, but I could have made it handle this case specifically to match variables. I didn't...

@sigurdm another downside is that all your downstream packages have to do the same. > I feel it is somewhat surprising for a package that works as a dart-only package...

> * We could bike-shed the name further, I'm open to ideas, `sdk-packages.yaml` just seemed natural. 🚲 🏠 Aren't underscores more common than dashes in file names in the Dart/Flutter...

> I think this should really live in dartdev What about `flutter pub run` though? That should share logic with `dart run`. And `package:flutter_tools` does _not_ import `package:dartdev`. We don't...