Daco Harkes
Daco Harkes
Right, `FfiCallbackMetadata::kPageSize` https://github.com/dart-lang/sdk/blob/bfe68f9ff552e3a11dcc218ee502feeee6299340/runtime/vm/ffi_callback_metadata.h#L205-L216 Could be reused for other things that require a memory block which is at least as large as a page on both host and target. Moving it...
These tests are now consistently failing in AOT: https://dart-current-results.web.app/#/filter=standalone/dwarf_stack_trace_obfuscate_test,standalone/dwarf_stack_trace_invisible_functions_test&showAll Example log: https://dart-ci.appspot.com/log/any/vm-aot-linux-debug-x64/288/standalone/dwarf_stack_trace_invisible_functions_test ``` --- Command "vm" (took 470ms): DART_CONFIGURATION=DebugX64 TEST_COMPILATION_DIR=/b/s/w/ir/out/DebugX64/generated_compilations/vm-aot-linux-debug-x64/tests_standalone_dwarf_stack_trace_invisible_functions_test out/DebugX64/dart_precompiled_runtime --dwarf-stack-traces --save-debugging-info=/b/s/w/ir/out/DebugX64/generated_compilations/vm-aot-linux-debug-x64/tests_standalone_dwarf_stack_trace_invisible_functions_test/dwarf_invisible_functions.so --sound-null-safety -Dtest_runner.configuration=vm-aot-linux-debug-x64 --ignore-unrecognized-flags --packages=/b/s/w/ir/.dart_tool/package_config.json /b/s/w/ir/out/DebugX64/generated_compilations/vm-aot-linux-debug-x64/tests_standalone_dwarf_stack_trace_invisible_functions_test/out.aotsnapshot exit code:...
@sstrickl It looks like we have an off-by-one error in the expected line in AOT in both these tests.
The test is flaking, but now mentions directory instead of notFound: ``` --- Command "vm" (took 03.000840s): set DART_CONFIGURATION=DebugX64C & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64C\crashpad_handler.exe & out\DebugX64C\dart.exe --sound-null-safety -Dtest_runner.configuration=vm-win-debug-x64c --ignore-unrecognized-flags...
Same error on co19/LibTest/io/Link/create_A06_t01 https://dart-ci.appspot.com/log/vm-aot-win-debug-x64c/vm-aot-win-debug-x64c/256/co19/LibTest/io/Link/create_A06_t01
> > * Use `calloc.free()` when freeing memory allocated in Dart (via `malloc`, or `toNativeUtf8` from `package:ffi`, for example) > > * Use a native function to free memory that...
> Since this would be a static check, could this still be possible by implementing `DartPointer` with a similar mechanism? Maybe if you're only interested in static checks (e.g. you...
> > (As a very off-topic tangent. With WASM-GC and multiple linear memories we also need to keep track of which memory a pointer belongs to. So we might need...
> @dcharkes If you want to try and add this, you can go for it. Alternatively, looks like `ios_host_app` is also an Add to App integration test (used in `module_test_ios.dart`)....
edit: nevermind, I removed the wrong lines locally. The other 3 copies of these lines in the file need to stay.