Daco Harkes comments

Results 171 comments of


                                            Daco Harkes

[vm/ffi] Allow extension types that implement `NativeType`s in FFI type arguments

Right, static members should be fine. I can make a fix for that. Are all the types that you want to wrap with documentation integer types? Do you have any...

[vm/ffi] Allow extension types that implement `NativeType`s in FFI type arguments

> There is an important difference between PWSTR and BSTR types. BSTR has a four-byte integer prefix that contains the number of bytes in the following data string. This means...

pkg/vm/test/transformations/ffi_test goes from flaky to Timeout failures

This test runs multiple tests in sequence, and every time we add new features to the FFI we add tests. We should consider setting up the tests differently so that...

[gardening/vm] vm/dart/devirtualization_during_inlining_il_test not inlining on all bots

FYI @mraleph It looks like the inliner doesn't inline properly on: * dartkp-weak-asserts-linux-release-x64 * vm-aot-optimization-level-linux-release-x64

[vm/ffi] NativeFinalizers with out parameters

Oh calling `NativeCallable.listener` from a `NativeFinalizer` doesn't work yet. I've filed: https://github.com/dart-lang/sdk/issues/54939. I've made an example on how this is supposed to work in: https://github.com/dart-lang/native/tree/native-finalizer/pkgs/native_assets_cli/example/native_add_library. We can clean it up...

[vm/ffi] NativeFinalizers with out parameters

As discussed offline with @liamappelbe and @mkustermann: 1. Resources should not be freed in Dart code. (Not the use case mentioned above.) When the isolate shuts down that would lead...

Direct support for entangled untagged pointers in the IL

> A. Avoid inner pointers to Dart heap objects in the IL entirely. Add corresponding canonicalization rules which would replace high-level operations taking Dart objects with low-level operations on raw...

Direct support for entangled untagged pointers in the IL

@sstrickl regarding `Pointer` and `ExternalTypedData` being optimized but `InternalTypedData` not, can we also optimize `TypedDataView`s on `ExternalTypedData`? Or is our current machinery not clever enough to deal with `kMayBeInnerPointer` and...

Direct support for entangled untagged pointers in the IL

Thanks for the write up @sstrickl! 🚀 > * Untagged values returned from `FfiCall` are never considered unsafe, since they are external pointers returned from C that are then stored...

Failures on new `dart2wasm-linux-optimized-jsc` builder that runs JavaScriptCore's shell

There are new test failures on [[CFE] Add a few helper utils...[dart2wasm] Roll binaryen to newer version](https://github.com/dart-lang/sdk/compare/2f0bbd9c09adca6cf6eee030d1722d9b3c3abe80~...29782f8750e847e82bde3aefb4970f4eba2e4cc3). The tests ``` co19/LanguageFeatures/Spread-collections/DynamicSemantics_Set_A03_t03 RuntimeError (expected Pass) co19/LibTest/async/StreamController/StreamController_A02_t01 RuntimeError (expected Pass) co19/LibTest/async/StreamController/addError_A01_t01 RuntimeError...