David Cantrell

> Two comments: > > 1. `excludes.txt` is a bit too generic for a name. Something like `rsync_excludes.txt` would be better for understanding what the file is without opening it....

The main objective is to allow rsync exclude pattern syntax in the external excludes list and avoid string manipulation problems that may come about while writing an excludes list as...

At this point in the life of dnf, we are unable to introduce a change like this. It would break the existing behavior which is not something we want to...

Sure, I can do that.

FWIW, everything here is ported and done: https://github.com/dcantrell/bsdutils/tree/master/src I can note what things are missing that are present in GNU coreutils. The DIFFERENCES file explains things that had to happen...

OK, got it to save 'newpackage'. But it still has this bogus list of bugs and it won't let me delete them.

I get this when I try to delete bugs from the update: Builds : Unable to create update. DELETE statement on table 'update_bug_table' expected to delete 1 row(s); Only 2...

> I have two proposals regarding the code I've reviewed. > > Firstly, as you suggested, I'd go with displaying the warning text to the user during the transaction confirmation,...

I don't follow here. How does this maintain the FreeBSD code base? I'm importing from releases of FreeBSD as they come out and libxo functionality is present. libxo is easy...

> The initial rationale was that you have removed features in the past, but a quick `grep "removed" DIFFERENCES` shows that it was because of OS incompatabilities. Right, that was...